RA-1641: inactive conditions should be displayed #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mseaton |
mogoodrich
reviewed
Dec 6, 2019
There was a problem hiding this comment.
Thanks @mozzy11 ! This looks good, but looking at it a little closer I'm wondering if instead of adding the getAllConditionHistory method we might just want to change the existing "getConditionHistory" to use the "getAllConditions" service method.
A "history" implies to me that it would get all conditions, not just the active conditions, and I'm guessing this endpoint is currently only being used in that one place in coreapps. What do you think?
|
true @mogoodrich , let work on that |
|
Hi @mogoodrich , i have updated the PR as per your suggestion |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket : https://issues.openmrs.org/browse/RA-1641
added a handler to return all Conditions