FM2-481: Clean up parameter passing for Task Service class search method #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #442 +/- ##
============================================
- Coverage 77.92% 77.88% -0.03%
- Complexity 2626 2631 +5
============================================
Files 242 243 +1
Lines 7327 7334 +7
Branches 908 908
============================================
+ Hits 5709 5712 +3
- Misses 1076 1079 +3
- Partials 542 543 +1
☔ View full report in Codecov by Sentry. |
ibacher
requested changes
May 30, 2023
There was a problem hiding this comment.
Thanks @mherman22! A couple of quick adjustments and I think this should be g2g.
| @@ -51,31 +43,9 @@ public class FhirTaskServiceImpl extends BaseFhirService<Task, FhirTask> impleme | |||
| @Autowired | |||
| private SearchQuery<FhirTask, Task, FhirTaskDao, TaskTranslator, SearchQueryInclude<Task>> searchQuery; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Please retain the Javadoc comments, removing the parts that are no longer relevant and adding for the new parameters.
ibacher
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/FM2-481
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master