FM2-481: Clean up parameter passing for Condition Service Search #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherman22
commented
Jul 15, 2023
api/src/main/java/org/openmrs/module/fhir2/api/impl/FhirConditionServiceImpl.java
Outdated
Show resolved
Hide resolved
mherman22
commented
Jul 15, 2023
api-2.2/src/main/java/org/openmrs/module/fhir2/api/impl/FhirConditionServiceImpl_2_2.java
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
============================================
- Coverage 77.24% 77.20% -0.04%
- Complexity 2648 2672 +24
============================================
Files 246 249 +3
Lines 7426 7464 +38
Branches 911 911
============================================
+ Hits 5736 5762 +26
- Misses 1142 1151 +9
- Partials 548 551 +3
☔ View full report in Codecov by Sentry. |
mherman22
force-pushed
the
FM2-481-Condition
branch
from
4fa1dc6
to
85e50a4
Compare
mherman22
commented
Jul 16, 2023
...java/org/openmrs/module/fhir2/providers/r4/ConditionFhirResourceProviderIntegrationTest.java
Show resolved
Hide resolved
mherman22
force-pushed
the
FM2-481-Condition
branch
from
85e50a4
to
eca771d
Compare
ibacher
reviewed
Jul 21, 2023
| DateRangeParam recordedDate, TokenAndListParam id, DateRangeParam lastUpdated, @Sort SortSpec sort, | ||
| HashSet<Include> includes) { | ||
| public IBundleProvider searchConditions(ConditionSearchParams conditionSearchParams) { | ||
| if (conditionSearchParams.getClinicalStatus() != null |
mherman22
force-pushed
the
FM2-481-Condition
branch
from
318f0e8
to
f3b4e90
Compare
ibacher
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/FM2-481
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master