FM2-582: Add Support for Patching on Immunization Resource #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #513 +/- ##
============================================
+ Coverage 77.06% 77.12% +0.06%
- Complexity 2673 2675 +2
============================================
Files 249 249
Lines 7480 7479 -1
Branches 912 909 -3
============================================
+ Hits 5764 5768 +4
+ Misses 1164 1163 -1
+ Partials 552 548 -4
☔ View full report in Codecov by Sentry. |
ibacher
reviewed
Jul 21, 2023
| private FhirContext fhirContext; | ||
| protected FhirContext fhirContext; |
mherman22
commented
Jul 22, 2023
| @@ -92,73 +92,6 @@ public Immunization create(@Nonnull Immunization newImmunization) { | |||
| return translator.toFhirResource(obs); | |||
| } | |||
|
|
|||
| @Override | |||
| public Immunization update(@Nonnull String uuid, @Nonnull Immunization updatedImmunization) { | |||
There was a problem hiding this comment.
removed the update aswell as patch since on addition of applyUpdate() override here, the rest of the stuff is duplication which can be minimized.
i.e
@Override
protected Immunization applyUpdate(Obs existingObject, Immunization updatedResource) {
OpenmrsFhirTranslator<Obs, Immunization> translator = getTranslator();
org.openmrs.Obs updatedObject;
if (translator instanceof OpenmrsFhirUpdatableTranslator) {
UpdatableOpenmrsTranslator<org.openmrs.Obs, Immunization> updatableOpenmrsTranslator = (OpenmrsFhirUpdatableTranslator<org.openmrs.Obs, Immunization>) translator;
updatedObject = updatableOpenmrsTranslator.toOpenmrsType(existingObject, updatedResource);
} else {
updatedObject = translator.toOpenmrsType(updatedResource);
}
validateObject(updatedObject);
return translator.toFhirResource(Context.getObsService().saveObs(updatedObject, "Updated via the FHIR2 API"));
}
|
@mherman22 LGTM. Do you want to include the other patching methods in this PR or a separate one? |
Looks like I forgot to include the rest of the integration tests. Will make a push and have them here . |
ibacher
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Ensures support of patch operations on the Immunization resource
Issue I worked on
see https://issues.openmrs.org/browse/FM2-582
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master