authentication-update: first pass #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,5 +105,16 @@ | |||
| <description>Ability to edit HL7 templates</description> | |||
| </privilege> | |||
|
|
|||
| <!-- Filters --> | |||
| <filter> | |||
| <filter-name>REST Web Service Authorization</filter-name> | |||
There was a problem hiding this comment.
You want to name your filter after your module :)
|
Done reviewing. Just a few small changes needed. |
|
Closing PR for lack of any activity in nearly two years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very very very crude first pass of the authentication problem at hand. I want to show it to you in order to prevent the authentication problem becoming a showstopper (as far as the release of h7query 1.0 is concerned)
I'm also rather hesitant to show you this because i'm sure its due to a stupid fault which I should be able to fix very easily.
Looking at the code, you'll see that i've added and renamed the BaseRestController. I've also introduced the SessionController and the ResponseException.
The problem of the hour is, why arn't they being called ? :-(