HTML-705: HTML Form Entry tag for creating a single condition #17
Conversation
api-2.2/.classpath
Outdated
| @@ -0,0 +1,27 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
I guess will need to update the .gitignore file
api-2.2/.project
Outdated
| @@ -0,0 +1,23 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
mks-d
changed the title
| StringBuilder ret = new StringBuilder(); | ||
| ret.append("<h5>"); | ||
| ret.append(mss.getMessage("coreapps.conditionui.addNewCondition")); | ||
| ret.append("</h5>"); |
There was a problem hiding this comment.
I don't think we want any title. Labels will be added when the tag is being used on the form.
| return ret.toString(); | ||
| } | ||
|
|
||
| public String createConditionNameWidget(FormEntryContext context) { |
There was a problem hiding this comment.
I see that you changed this signature, but why has this become public then?
I would rather see a protected method named htmlForConditionSearchWidget(FormEntryContext) so that it reads like this:
ret.append(htmlForConditionSearchWidget(context));There was a problem hiding this comment.
Ok man, that naming sounds just perfect.
I see that you changed this signature, but why has this become public then?
Actually that was a mistake, your right anyway
| return conditionStatusWidget.generateHtml(context) + sb.toString(); | ||
| } | ||
|
|
||
| private String createConditionDateWidgets(FormEntryContext context) { |
There was a problem hiding this comment.
I would rather see a protected method named htmlForConditionDateWidgets(FormEntryContext).
There was a problem hiding this comment.
Why don't we have it private ?
| return ret.toString(); | ||
| } | ||
|
|
||
| private String createConditionStatusWidgets(FormEntryContext context) { |
There was a problem hiding this comment.
I would rather see a protected method named htmlForConditionStatusWidgets(FormEntryContext).
There was a problem hiding this comment.
Why don't we have it private ?
| private DateWidget onsetDate; | ||
|
|
||
| @Before | ||
| public void setup() { |
There was a problem hiding this comment.
The setup enforces too many things IMO.
Let's discuss this.
mks-d
changed the title
|
New draft PR : #18 |
No description provided.