[LUI-66] Concept Proposal Form is broken #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Jan 10, 2018
| @@ -134,8 +134,8 @@ | |||
| class='searchHit'> | |||
| ${status.index + 1}) | |||
| <c:choose > | |||
| <c:when test="${listItem.synonym != ''}"> | |||
| <span class='mainHit'>${listItem.synonym}</span> | |||
| <c:when test="${listItem.description != ''}"> | |||
There was a problem hiding this comment.
From here, https://github.com/openmrs/openmrs-core/blob/1.12.x/web/src/main/java/org/openmrs/web/dwr/ConceptListItem.java#L46-L53 the synonym was deprecated and hence removed. Therefore, just remove the choose and simply use listItem.name which is already in the otherwise section.
There was a problem hiding this comment.
Thank you. I was viewing the wrong ConceptListItem.java so didn't find this deprecated statement.
There was a problem hiding this comment.
No. You did not look at the wrong guy. You just looked after it was deprecated and eventually removed. 😊
There was a problem hiding this comment.
Ah, on an older version, that makes sense.
|
The changes have been made @dkayiwa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.openmrs.org/browse/LUI-66