LUI-128 Add new Provider Attribute Type #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Jan 10, 2018
| return datatype.deserialize(formFieldValue); | ||
| } | ||
|
|
||
| private boolean isInteger(String value) { | ||
| return value.matches("-?\\d+"); |
There was a problem hiding this comment.
There should be a java library for this.
There was a problem hiding this comment.
StringUtils.isNumeric() would be ok?
dkayiwa
reviewed
Jan 10, 2018
| if (StringUtils.isNumeric(formFieldValue)) { | ||
| BaseOpenmrsObject metadata = null; | ||
| PropertyEditor editor; | ||
|
|
There was a problem hiding this comment.
Can you add some unit tests for these?
There was a problem hiding this comment.
@dkayiwa Done :) I've managed to get 100% coverage
dkayiwa
reviewed
Jan 11, 2018
| @Test | ||
| public void getValue_givenLocationId_shouldCallDeserializeWithLocationUuid() throws Exception { | ||
| List<Location> locations = Context.getLocationService().getAllLocations(); | ||
| Location testedLocation = locations.get(0); |
There was a problem hiding this comment.
Instead of getting all and then the first, why not just get for a particular id? You can pick them from here: https://github.com/openmrs/openmrs-core/blob/master/api/src/test/resources/org/openmrs/include/standardTestDataset.xml
There was a problem hiding this comment.
@dkayiwa Done :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.openmrs.org/browse/LUI-128