Change all 'emr.' messages to 'coreapps.' equivalents #95
Conversation
|
I went through and checked which ones actually exist in coreapps. Apparently a lot of messages just didn't get migrated, or they were migrated and then removed later. Those messages I'm leaving on |
There was a problem hiding this comment.
Ugh. So when I reviewed this ticket, I didn't realize that a lot of these message codes were being used in UI Commons.
The issue is that Core Apps depends on UI Common so we've got a (light) circular dependency here now. This probably isn't a problem, because I think everyone who uses UI Commons uses Core Apps, but I'm not sure about that... and also, as we try to phase out the 2.0 UI the future it might mean we need to keep Core Apps around longer than we'd like.
My quick thoughts:
-
Move all the "emr.*" properties in the UI Commons messages.properties to the bottom of the file and add a comment that these are deprecated (I think Transifex will maintain comments)
-
Copy all the "emr." properties to new "uicommons." properties and add them to the messages.properties file
-
Do the same in all the message_* files
-
Force push up all the Transifex files
-
Change all usages of "emr." and "coreapps. in UI Commones to "uicommons.*"
I'm open to better suggestions. Alternatively, you could just target the ones that are causing a problem?
(The issue he that we copied over the "emr.*" properties from the defunct EMR module back in the day and didn't bite the bullet then and rename them.)
|
Closing in favor of PIH/openmrs-module-emr#6 |
No description provided.