Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCLOMRS-33: Implements logic for retrieving and searching for concepts #32

Merged
merged 1 commit into from
Jun 17, 2018

Conversation

hadijahkyampeire
Copy link
Collaborator

JIRA TICKET NAME:

OCLOMRS-33: Implements logic for retrieving and searching for concepts

Summary:

This PR does the following:

  • Adds UI for viewing all concepts in OCL
  • Implements the logic for retrieving all concepts and searching through them
  • Adds tests for all the functionality

@coveralls
Copy link

coveralls commented Jun 14, 2018

Pull Request Test Coverage Report for Build 160

  • 48 of 58 (82.76%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 67.857%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/dashboard/container/Concepts.jsx 14 15 93.33%
src/redux/actions/concepts/index.js 9 18 50.0%
Totals Coverage Status
Change from base Build 155: 1.9%
Covered Lines: 232
Relevant Lines: 317

💛 - Coveralls

Copy link
Contributor

@shakirandagire shakirandagire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/App.js Outdated
@@ -18,6 +19,7 @@ const App = () => (
<Switch>
<Route exact path="/" component={Login} />
<Route exact path="/dashboard" component={Authenticate(SourceSearch)} />
<Route exact path="/dashboard/concepts" component={Authenticate(ConceptSerach)} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be a typo here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What typo @emasys

<tr className="concept-table">
<td>{id}</td>
<td style={{ maxWidth: '25rem' }} className="display-name">
{/* <div style={{ maxWidth: '25rem' }} className="display-name"> */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do well to delete these comments

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@hadijahkyampeire hadijahkyampeire changed the title OCLOMRS-033: Implements logic for retrieving and searching for concepts OCLOMRS-33: Implements logic for retrieving and searching for concepts Jun 14, 2018
@mwaz
Copy link
Contributor

mwaz commented Jun 14, 2018

LGTM

@hadijahkyampeire hadijahkyampeire force-pushed the OCLOMRS-033 branch 3 times, most recently from 9b1908f to c1e506b Compare June 14, 2018 13:08
@EleisonC
Copy link
Contributor

Why is Travis failing

@hadijahkyampeire
Copy link
Collaborator Author

Everything is good now

Copy link
Contributor

@EleisonC EleisonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkayiwa dkayiwa merged commit c2856f8 into openmrs:master Jun 17, 2018
hadijahkyampeire added a commit to hadijahkyampeire/openmrs-ocl-client that referenced this pull request Jun 20, 2018
…ts (openmrs#32)

fix tests

OCLOMRS-41: User shouldn't see the login page when they are loggedin
kirity-mahanty pushed a commit that referenced this pull request Aug 28, 2020
… API GET call (#32) (#610)

Bindu, Supriya | OCLOMRS-872 | MOBN-1443 | Update the organisation API GET call to … (#33)

* Bindu, Supriya | OCLOMRS-872 | MOBN-1443 | Update the organisation API GET call to fetch only user specific organisations

* Supriya, Bindu | OCLOMRS-872 | MOBN-1443 | Handling review comments

* Bindu, Supriya | OCLOMRS-872 | MOBN-1443 | Make the order of dictionary tabs same as source page

Co-authored-by: supriyatw <45252490+supriyatw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants