-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCLOMRS-33: Implements logic for retrieving and searching for concepts #32
Conversation
Pull Request Test Coverage Report for Build 160
💛 - Coveralls |
1317205
to
4193c25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/App.js
Outdated
@@ -18,6 +19,7 @@ const App = () => ( | |||
<Switch> | |||
<Route exact path="/" component={Login} /> | |||
<Route exact path="/dashboard" component={Authenticate(SourceSearch)} /> | |||
<Route exact path="/dashboard/concepts" component={Authenticate(ConceptSerach)} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be a typo here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What typo @emasys
<tr className="concept-table"> | ||
<td>{id}</td> | ||
<td style={{ maxWidth: '25rem' }} className="display-name"> | ||
{/* <div style={{ maxWidth: '25rem' }} className="display-name"> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do well to delete these comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool
ba08005
to
82dda67
Compare
LGTM |
9b1908f
to
c1e506b
Compare
Why is Travis failing |
a81e1e1
to
15acf63
Compare
Everything is good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ts (openmrs#32) fix tests OCLOMRS-41: User shouldn't see the login page when they are loggedin
… API GET call (#32) (#610) Bindu, Supriya | OCLOMRS-872 | MOBN-1443 | Update the organisation API GET call to … (#33) * Bindu, Supriya | OCLOMRS-872 | MOBN-1443 | Update the organisation API GET call to fetch only user specific organisations * Supriya, Bindu | OCLOMRS-872 | MOBN-1443 | Handling review comments * Bindu, Supriya | OCLOMRS-872 | MOBN-1443 | Make the order of dictionary tabs same as source page Co-authored-by: supriyatw <45252490+supriyatw@users.noreply.github.com>
JIRA TICKET NAME:
OCLOMRS-33: Implements logic for retrieving and searching for concepts
Summary:
This PR does the following: