OCLOMRS-932: Hide retired concepts & add option to include retired concepts

[jwnasambu]

JIRA TICKET NAME:

General Filter: Hide Retired Concepts & Add Filter option to Include Retired Concepts

Summary:

I changed includeRetired: includeRetired ? 1 : 0
Back to :

includeRetired

to enable filtering of retired concepts well.

[HerbertYiga]

General Filter: Hide Retired Concepts & Add Filter option to Include Retired Concepts

not sure why this link keeps breaking at my side

[jwnasambu]

@HerbertYiga its failing because of this ERROR: Service 'solr' failed to build: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.

[hadijahkyampeire]

@ibacher please review this, I think we need to maintain the 1 and 0, if anything we actually need to change the true and false since APIv2 is using 1 and 0, we need to spec this ticket well because it looks like it has been confusing over time.

[hadijahkyampeire]

@jwnasambu please rebase your branch with master to get the test fixes.

[ibacher]

@hadijahkyampeire I'm going from the OCL interface v2 which seems to use true/false. Here are requests I see when toggling the includeRetired setting in the UI:

https://api.openconceptlab.org/concepts/?q=dxtest&page=1&limit=25&includeRetired=false&verbose=false&sortDesc=last_update

https://api.openconceptlab.org/concepts/?q=dxtest&page=1&limit=25&includeRetired=true&verbose=false&sortDesc=last_update

So I think we really do want true / false there rather than 1 or 0. See also the underlying API code that handles this. It's API v1 that uses 1 / 0 or rather (I'm guessing) something that evaluates to True in Python. Maybe True / False would work for both?

[ibacher]

@jwnasambu Can you rebase this on the lastest master which should fix the test failures?

[jwnasambu]

@ibacher on my terminal I run this commands,

• git checkout OCLOMRS-932
• git rebase master

and ended up with this output Current branch OCLOMRS-932 is up to date. but the Travis CI is still failing could there be something I'm missing out?

[ibacher]

Is your local master up to date? Try doing:

git fetch --all
git rebase upstream master

You might have to do a git push --force afterwards to update the branch.

[jwnasambu]

@ibacher Thanks so much am so glad the build is successful. This is an achievement!

[hadijahkyampeire]

@ibacher @jwnasambu I think this ticket has many files which are other people commits, we need to rebase it well to have only commits for this PR.

[ibacher]

@hadijahkyampeire That's a good point. Done.

[coveralls]

Coverage decreased (-0.003%) to 44.713% when pulling 997f5e4 on jwnasambu:OCLOMRS-932 into 9232b52 on openmrs:master.