-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCLOMRS-932: Hide retired concepts & add option to include retired concepts #685
Conversation
not sure why this link keeps breaking at my side |
@HerbertYiga its failing because of this ERROR: |
@ibacher please review this, I think we need to maintain the 1 and 0, if anything we actually need to change the true and false since APIv2 is using 1 and 0, we need to spec this ticket well because it looks like it has been confusing over time. |
@jwnasambu please rebase your branch with master to get the test fixes. |
@hadijahkyampeire I'm going from the OCL interface v2 which seems to use So I think we really do want |
@jwnasambu Can you rebase this on the lastest |
@ibacher on my terminal I run this commands,
and ended up with this output |
Is your local
You might have to do a |
@ibacher Thanks so much am so glad the build is successful. This is an achievement! |
@ibacher @jwnasambu I think this ticket has many files which are other people commits, we need to rebase it well to have only commits for this PR. |
… to Include Retired Concepts
@hadijahkyampeire That's a good point. Done. |
JIRA TICKET NAME:
General Filter: Hide Retired Concepts & Add Filter option to Include Retired Concepts
Summary:
I changed includeRetired: includeRetired ? 1 : 0
Back to :
includeRetired
to enable filtering of retired concepts well.