Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCLOMRS-965:Set Source to whatever user want it to be (maybe “Your Recent Sources” instead of hardcoded) #691

Closed
wants to merge 13 commits into from

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Apr 15, 2021

JIRA TICKET NAME:

Set Source to whatever user want it to be (maybe “Your Recent Sources” instead of hardcoded)

Summary:

I added MySource option on the public source to enable a user add concepts to the dictionary from his/her source.

@coveralls
Copy link

coveralls commented Apr 15, 2021

Coverage Status

Coverage increased (+0.01%) to 45.476% when pulling 46c56a8 on jwnasambu:OCLOMRS-965 into 07beef6 on openmrs:master.

@@ -289,12 +289,14 @@ export const MAP_TYPE_CONCEPT_SET = option("CONCEPT-SET");
const CIEL_SOURCE_URL = "/orgs/CIEL/sources/CIEL/";
const PIH_SOURCE_URL = "/orgs/PIH/sources/PIH/";
const MSFOCP_SOURCE_URL = "/orgs/MSFOCP/sources/MSFOCP/";
const MySource_SOURCE_URL = "/orgs/MySource/sources/MySource/";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HerbertYiga am missing your comment? I did that basing on this lick https://docs.google.com/presentation/d/1Q2yMyxTQrflQGc-O77KlGEXiPC_savon9ju9LDUaI5c/edit#slide=id.gd2498758a4_0_14 shared by Suruchi and the output is attached on the ticket.

Copy link
Collaborator

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwnasambu thanks for starting on this, but what is actually needed is not just the word MySource it was just an example that Suruchi used, it means to list all available user sources and public sources so that users can also pick from them rather than the hardcoded sources we currently have.

@jwnasambu
Copy link
Contributor Author

@hadijahkyampeire thanks for the clarification. Kindly, it sounds good when the tickets have clear description of what is expected if possible with diagram(s).

@hadijahkyampeire
Copy link
Collaborator

You are right @jwnasambu I will ping the reporter to add more useful information that you can work with.

@jwnasambu jwnasambu marked this pull request as draft May 7, 2021 14:26
@jwnasambu jwnasambu closed this May 10, 2021
@jwnasambu jwnasambu deleted the OCLOMRS-965 branch May 10, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants