OCLOMRS-84: Redesign user dashboard #74
Conversation
Pull Request Test Coverage Report for Build 388
💛 - Coveralls |
emasys
force-pushed
the
OCLOMRS-84
branch
2 times, most recently
from
3915336
to
209994c
Compare
| numberOfDictionary: PropTypes.number.isRequired, | ||
| organizations: PropTypes.array.isRequired, | ||
| }; | ||
|
|
There was a problem hiding this comment.
This component is rendering three different views based on some condition, don't you think it'll be better if these three different views are modularised as it would aid reusability and make this component look more compact.
Each possible view in this component has the div tag with className user-data and a p tag with className lead, I think it'll be better if you write this without having to repeat this tags in the different views.
There was a problem hiding this comment.
Thanks for your feedback. However, if you closely look at the component you'd see there's no point modularizing any part of this component. Inasmuch as all the blocks look similar I would like you to take a closer look at the lines below:
- 12
- 26
- 58
Trying to break this component furthermore will only make it more difficult to understand or edit in the future.
Thanks again. @Efosaok
There was a problem hiding this comment.
sorry I forgot to approve this earlier, I just felt it would be better modularizing this component, but if you insist it's better this way for this project, it's fine as well. as for the templating on those lines, correct me if I am wrong, but I do not see how modularizing it affects that part. the child component could receive the value as props.
There was a problem hiding this comment.
My point exactly, I don't think that is necessary. Thanks a lot.
JIRA TICKET NAME:
Redesign the user dashboard to follow the provided mockup
Summary:
As a user, after signing in to the app, I should see a user dashboard similar to what is in the mockup