OCLOMRS-1046:Paging, searching and filtering through the list of concepts no longer works #742
Conversation
|
@jwnasambu , thanks for the PR but it's not loading any concepts at my end. |
|
@suruchee thanks for the feedback! Basing on the PR this is what I have that I believe was supposed to be done basing on the ticket discription. screencast.2021-09-13.7.PM-42-29.mp4Alternatively if you are not seeing concepts you can search then play around with the table pagination buttons |
| @@ -268,7 +268,23 @@ const ViewConceptsPage: React.FC<Props> = ({ | |||
| // i don't know how the comparison algorithm works, but for these arrays, it fails. | |||
| // stringify the arrays to work around that | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
| }, [retrieveConcepts, retrieveDictionary, retrieveSource, containerUrl]); | |||
| }, [ | |||
| retrieveConcepts, | |||
jwnasambu
force-pushed
the
OCLOMRS-1046
branch
from
511a716
to
43aba81
Compare
|
@suruchi you can try testing again. |
There was a problem hiding this comment.
Thanks for the fix @jwnasambu , this works fine, it looks like you and @suruchee have submitted the same work, we should merge one of the PRs and close the other.
hadijahkyampeire
changed the title
@hadijahkyampeire Oh sorry! its unfortunate but I was the one who claimed the ticket and I was working on it. It's not good to work on someone's ticket without there consent. |
|
It's okay @jwnasambu it was a mistake with the reporting of the tickets, they made two different tickets but which were addressing the same issue, that's why you both had tickets that are different but solving the same issue, I have told @suruchee to rebase with your work and cover some other work in her PR since you have already addressed what she has in her PR. |
JIRA TICKET NAME:
Paging through the list of concepts no longer works
Summary: