AOM-135: Display all Maintainers/Developers names on the addon page #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 584
💛 - Coveralls |
|
look goods to me 👍 |
dkayiwa
reviewed
Feb 1, 2018
| @@ -330,7 +336,7 @@ class Addon extends Component { | |||
| <div className="title-container"> | |||
| <h3 id="addon-name">{app.name}</h3> | |||
| <p id="addon-description">{app.description}</p> | |||
| {app.uuid ? | |||
| {app.uid || app.uuid ? | |||
There was a problem hiding this comment.
What are the cases where it is uid instead of uuid?
There was a problem hiding this comment.
The new response i am getting when i fetch modules is its uid and no longer uuid.
I left the uuid deliberately for future response
There was a problem hiding this comment.
Ignore the future. We shall change it if that future comes.
There was a problem hiding this comment.
Okay, i have updated the PR
Charpell
force-pushed
the
AOM-135
branch
3 times, most recently
from
d72d7cb
to
7941324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA TICKET NAME
AOM-135: Display all Maintainers/Developers names on the addon page
SUMMARY
Currently there is only one Maintainers/Developers name displayed when a user clicks the view button to see an add-on. In a situation where the Maintainers/Developers names are not completely displayed on the add-on manager page, it is necessary to display all the names in the add-on page.
This ticket aims to address this issue