CB-160: query description does not specify constraints applied to a query in search history #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry description does not specify the constraints applied to a query in search history
tduyile04
reviewed
Nov 7, 2017
| @@ -0,0 +1,30 @@ | |||
| /** | |||
| * takes in a date string and returns it in the format dd/mm/yy | |||
There was a problem hiding this comment.
Nice separation of concerns here. 👍
|
looks good |
LWanjiru
reviewed
Nov 7, 2017
| expect(queryDescriptionBuilder(mockStateWithMoreData, mockConceptName)) | ||
| .to.equal('Patients with ANY Weight (Kg) < 20 since 1/12/2016 until 1/11/2017'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Awesome work with the tests, I will need your help figuring out a few things on testing myself.
PR looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA TICKET NAME:
Concept/Observation - On numeric concept ("Weight (kg)”), query description does not specify the constraints applied to a query in search history.
SUMMARY:
This PR ensures that when a search query is done, there's a description in the search history that contains the search parameters/constraints applied