-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-172: Reset form when user clicks ‘Search’ - Saved #158
Conversation
* @return {undefined} | ||
*/ | ||
handleReset() { | ||
this.state = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not mutate state directly. Use setState() react/no-direct-mutation-state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Good work @joel-ace . Since you are already working on this file, take a look at this article that was shared with the OpenMRs devs in September regarding code comments |
Thank's @cnagadya I've read that article before. I didn't take out those comments for two reasons:
|
JIRA TICKET NAME:
Reset form when user clicks ‘Search’ - Saved
SUMMARY:
This PR ensures that on the "Saved" tab, the form is reset when the Search button is clicked