SDK-312: Allow overriding openmrs assemble and build tool versions

[wikumChamith]

This allows users to override the default OpenMRS SPA core version using the maven parameter: spaCoreVersion.

Jira ticket: https://issues.openmrs.org/browse/SDK-312

[dkayiwa]

@wikumChamith can you add this to the documentation?

[dkayiwa]

And will this replace latest in what i have in the log as Running 'npm exec -- openmrs@latest build --target.....

[wikumChamith]

Yes.

openmrs-sdk/maven-plugin/src/main/java/org/openmrs/maven/plugins/utility/SpaInstaller.java

Lines 47 to 86 in 806a9e6

	public void installFromDistroProperties(File appDataDir, DistroProperties distroProperties)
	throws MojoExecutionException {
	// We find all the lines in distro properties beginning with `spa` and convert these
	// into a JSON structure. This is passed to the frontend build tool.
	// If no SPA elements are present in the distro properties, the SPA is not installed.
	Map<String, String> spaProperties = distroProperties.getSpaProperties(distroHelper, appDataDir);
	// Three of these properties are not passed to the build tool, but are used to specify the build execution itself
	String coreVersion = spaProperties.remove("core");
	if (coreVersion == null) {
	coreVersion = "latest";
	}
	String nodeVersion = spaProperties.remove("node");
	if (nodeVersion == null) {
	nodeVersion = NODE_VERSION;
	}
	String npmVersion = spaProperties.remove("npm");
	if (npmVersion == null) {
	npmVersion = NPM_VERSION;
	}
	if (!spaProperties.isEmpty()) {
	Map<String, Object> spaConfigJson = convertPropertiesToJSON(spaProperties);
	File spaConfigFile = new File(appDataDir, "spa-build-config.json");
	writeJSONObject(spaConfigFile, spaConfigJson);
	nodeHelper.installNodeAndNpm(nodeVersion, npmVersion);
	File buildTargetDir = new File(appDataDir, BUILD_TARGET_DIR);
	String program = "openmrs@" + coreVersion;
	// print frontend tool version number
	nodeHelper.runNpx(String.format("%s --version", program));
	nodeHelper.runNpx(
	String.format("%s build --target %s --build-config %s", program, buildTargetDir, spaConfigFile));
	nodeHelper.runNpx(
	String.format("%s assemble --target %s --mode config --config %s", program, buildTargetDir, spaConfigFile));
	}
	}

[wikumChamith]

Yes.

openmrs-sdk/maven-plugin/src/main/java/org/openmrs/maven/plugins/utility/SpaInstaller.java

Lines 47 to 86 in 806a9e6

	public void installFromDistroProperties(File appDataDir, DistroProperties distroProperties)
	throws MojoExecutionException {
	// We find all the lines in distro properties beginning with `spa` and convert these
	// into a JSON structure. This is passed to the frontend build tool.
	// If no SPA elements are present in the distro properties, the SPA is not installed.
	Map<String, String> spaProperties = distroProperties.getSpaProperties(distroHelper, appDataDir);
	// Three of these properties are not passed to the build tool, but are used to specify the build execution itself
	String coreVersion = spaProperties.remove("core");
	if (coreVersion == null) {
	coreVersion = "latest";
	}
	String nodeVersion = spaProperties.remove("node");
	if (nodeVersion == null) {
	nodeVersion = NODE_VERSION;
	}
	String npmVersion = spaProperties.remove("npm");
	if (npmVersion == null) {
	npmVersion = NPM_VERSION;
	}
	if (!spaProperties.isEmpty()) {
	Map<String, Object> spaConfigJson = convertPropertiesToJSON(spaProperties);
	File spaConfigFile = new File(appDataDir, "spa-build-config.json");
	writeJSONObject(spaConfigFile, spaConfigJson);
	nodeHelper.installNodeAndNpm(nodeVersion, npmVersion);
	File buildTargetDir = new File(appDataDir, BUILD_TARGET_DIR);
	String program = "openmrs@" + coreVersion;
	// print frontend tool version number
	nodeHelper.runNpx(String.format("%s --version", program));
	nodeHelper.runNpx(
	String.format("%s build --target %s --build-config %s", program, buildTargetDir, spaConfigFile));
	nodeHelper.runNpx(
	String.format("%s assemble --target %s --mode config --config %s", program, buildTargetDir, spaConfigFile));
	}
	}

I tested this. The value we passed gets set in String coreVersion = spaProperties.remove("core"); .

[wikumChamith]

@wikumChamith can you add this to the documentation?

@dkayiwa I updated the documentation: https://wiki.openmrs.org/pages/viewpage.action?pageId=224527013#O3ImplementerDocumentation:SetUp,Configure&Deploy-SetuptheO3distributionwiththeSDK.

[dkayiwa]

Should the default be latest or next?

[wikumChamith]

Should the default be latest or next?

By default in other spa modules, we use the 'next' version. Using the latest version for spa core was added in this issues: https://issues.openmrs.org/browse/SDK-290

What do you recommend??

[wikumChamith]

Should the default be latest or next?

By default in other spa modules, we use the 'next' version. Using the latest version for spa core was added in this issues: https://issues.openmrs.org/browse/SDK-290

What do you recommend??

Pr: #197

[dkayiwa]

Shouldn't we be consistent?

[wikumChamith]

Shouldn't we be consistent?

Yeah. I'll change the default version to next.

[wikumChamith]

@dkayiwa I changed the default version to next. I also updated the documentation.