STAND-102:Replace the embedded mysql with mariadb4j? #46

sherrif10 · 2020-07-12T10:20:39Z

https://issues.openmrs.org/browse/STAND-102

cc @dkayiwa , i didnot entail to completely exclude mysql connectors since we cannot completely run on mariadb, we are to use mariadb in response to mysql, More suggestion will be appreciated thanks

dkayiwa · 2020-07-12T14:32:48Z

@sherrif10 did you test this?

sherrif10 · 2020-07-12T18:15:24Z

Have been testing it and landed into some error, however am trying to get them fixed

sherrif10 · 2020-07-12T20:06:36Z

Hey @dkayiwa , the unfortunate thing is that i cannot connect to the database server using the mariadb, do i need to add mariadb connectors in place of mysql connectors, thats seems to be challenging me because am thinking of it at a perspective of other files that depend on mysql, And i think the main idea is not completely run on mariadb, Any suggestion thanks

HerbertYiga · 2020-07-13T02:54:54Z

pom.xml

@@ -1,4 +1,4 @@
-<project xmlns="http//maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ <project xmlns="http//maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"


@sherrif10 thanks for working on this,was this change important?

Thats a minor change

HerbertYiga · 2020-07-13T02:57:48Z

pom.xml

-			<groupId>mysql</groupId>
-			<artifactId>mysql-connector-mxj-db-files-fixed</artifactId>
-			<version>5.0.12-20170418</version>
+			<groupId>ch.vorburger.mariaDB4j</groupId>


@sherrif10 introducing maria db dependency only cannot make us run on maria db,we also need the maria db connector

Thanks @HerbertYiga, however mariadb can work fine with mysql connectors without even any modification

@sherrif10 ohh yes,point noted.Could this be of use to you too https://mariadb.com/kb/en/mariadb-vs-mysql-compatibility/

@dkayiwa shared that to me earlier thanks again @HerbertYiga

sherrif10 · 2020-07-14T19:27:55Z

This work is under Progress and under testing. cc @dkayiwa @ibacher, Would you love reviewing this PR. thanks

sherrif10 · 2020-07-14T22:45:29Z

We can now run on mariaDB4J however testing it on standalone is still goin on

sherrif10 · 2020-07-15T08:06:14Z

Connections are now succesfull with latest changes as pers screenshot her
. The link to openmrs talk thread here cc @dkayiwa @ibacher

ibacher

These are just some minor fixes.

ibacher · 2020-07-20T14:59:16Z

pom.xml

+				<liquibasePluginArtifactId>liquibase-maven-plugin
+				</liquibasePluginArtifactId>


Suggested change

<liquibasePluginArtifactId>liquibase-maven-plugin

</liquibasePluginArtifactId>

<liquibasePluginArtifactId>liquibase-maven-plugin</liquibasePluginArtifactId>

Thanks for coming up for this, Are you suggesting i remove this

No, just move it back to a single line like this: <liquibasePluginArtifactId>liquibase-maven-plugin</liquibasePluginArtifactId>

ohhh thanks, let me do that

ibacher · 2020-07-20T14:59:51Z

pom.xml

+				<liquibaseDemoDataFileName>liquibase-demo-data.xml
+				</liquibaseDemoDataFileName>
+				<liquibasecielDataFileName>liquibase-ciel-data.xml
+				</liquibasecielDataFileName>
+				<liquibaseDemoDataFollowupFileName>liquibase-empty-changelog.xml
+				</liquibaseDemoDataFollowupFileName>
+				<liquibaseEmptyDbFollowupFileName>liquibase-empty-changelog.xml
+				</liquibaseEmptyDbFollowupFileName>


Suggested change

<liquibaseDemoDataFileName>liquibase-demo-data.xml

</liquibaseDemoDataFileName>

<liquibasecielDataFileName>liquibase-ciel-data.xml

</liquibasecielDataFileName>

<liquibaseDemoDataFollowupFileName>liquibase-empty-changelog.xml

</liquibaseDemoDataFollowupFileName>

<liquibaseEmptyDbFollowupFileName>liquibase-empty-changelog.xml

</liquibaseEmptyDbFollowupFileName>

<liquibaseDemoDataFileName>liquibase-demo-data.xml</liquibaseDemoDataFileName>

<liquibasecielDataFileName>liquibase-ciel-data.xml</liquibasecielDataFileName>

<liquibaseDemoDataFollowupFileName>liquibase-empty-changelog.xml</liquibaseDemoDataFollowupFileName>

<liquibaseEmptyDbFollowupFileName>liquibase-empty-changelog.xml</liquibaseEmptyDbFollowupFileName>

ibacher · 2020-07-20T15:00:01Z

pom.xml

+				<liquibasePluginArtifactId>liquibase-plugin
+				</liquibasePluginArtifactId>


Suggested change

<liquibasePluginArtifactId>liquibase-plugin

</liquibasePluginArtifactId>

<liquibasePluginArtifactId>liquibase-plugin</liquibasePluginArtifactId>

ibacher · 2020-07-20T15:00:18Z

pom.xml

+		<ciel.dictionary.openmrs.version>1.9.9
+		</ciel.dictionary.openmrs.version>


Suggested change

<ciel.dictionary.openmrs.version>1.9.9

</ciel.dictionary.openmrs.version>

<ciel.dictionary.openmrs.version>1.9.9</ciel.dictionary.openmrs.version>

ibacher · 2020-07-20T15:00:45Z

pom.xml

+				<liquibaseDemoDataFileName>liquibase-demo-data-18x.xml
+				</liquibaseDemoDataFileName>
+				<liquibasecielDataFileName>liquibase-ciel-data-18x.xml
+				</liquibasecielDataFileName>
+				<liquibaseDemoDataFollowupFileName>liquibase-rename-helper-tables-18x.xml
+				</liquibaseDemoDataFollowupFileName>
+				<liquibaseEmptyDbFollowupFileName>liquibase-rename-helper-tables-18x.xml
+				</liquibaseEmptyDbFollowupFileName>


Suggested change

<liquibaseDemoDataFileName>liquibase-demo-data-18x.xml

</liquibaseDemoDataFileName>

<liquibasecielDataFileName>liquibase-ciel-data-18x.xml

</liquibasecielDataFileName>

<liquibaseDemoDataFollowupFileName>liquibase-rename-helper-tables-18x.xml

</liquibaseDemoDataFollowupFileName>

<liquibaseEmptyDbFollowupFileName>liquibase-rename-helper-tables-18x.xml

</liquibaseEmptyDbFollowupFileName>

<liquibaseDemoDataFileName>liquibase-demo-data-18x.xml</liquibaseDemoDataFileName>

<liquibasecielDataFileName>liquibase-ciel-data-18x.xml</liquibasecielDataFileName>

<liquibaseDemoDataFollowupFileName>liquibase-rename-helper-tables-18x.xml</liquibaseDemoDataFollowupFileName>

<liquibaseEmptyDbFollowupFileName>liquibase-rename-helper-tables-18x.xml</liquibaseEmptyDbFollowupFileName>

ibacher · 2020-07-20T15:02:38Z

pom.xml

+			<url>http://mavenrepo.openmrs.org/nexus/content/repositories/public
+			</url>


Suggested change

<url>http://mavenrepo.openmrs.org/nexus/content/repositories/public

</url>

<url>http://mavenrepo.openmrs.org/nexus/content/repositories/public</url>

ibacher · 2020-07-20T15:02:54Z

src/main/java/org/openmrs/standalone/StopEmbeddedMySQL.java

+
+

Suggested change

ibacher · 2020-07-20T15:03:21Z

src/main/java/org/openmrs/standalone/StopEmbeddedMySQL.java

@@ -29,6 +32,7 @@ public static void main(String[] args) throws Exception {

 		for (int i = 0; i < args.length; i++) {
 			ServerLauncherSocketFactory.shutdown(new File(args[i]), null);
-        }
+       }


Suggested change

}

}

ibacher · 2020-07-20T15:03:29Z

src/main/java/org/openmrs/standalone/StopEmbeddedMySQL.java

 	}
+
 }


Suggested change

}

}

ibacher · 2020-07-20T15:03:38Z

src/main/resources/org/openmrs/standalone/setup-openmrs-user.sql

@@ -0,0 +1,3 @@
+CREATE USER 'openmrs'@'%' IDENTIFIED BY 'test';
+GRANT ALL PRIVILEGES ON openmrs.* to 'openmrs'@'%';
+FLUSH PRIVILEGES;


Suggested change

FLUSH PRIVILEGES;

FLUSH PRIVILEGES;

Finished, hope it looks fine now

sherrif10 · 2020-07-23T10:44:05Z

Hello @dkayiwa @ibacher ,As we are trying to implement the class that launches standalone on mariaDB , included a simple class, could you have time and guide me on this, thanks

https://issues.openmrs.org/browse/STAND-102

sherrif10 · 2020-07-30T19:36:14Z

src/main/java/MariaDbLauncher.java

@@ -0,0 +1,35 @@
+/**


cc @ibacher @dkayiwa , back on this ticket, could you take a review about this class

sherrif10 · 2020-08-05T12:32:59Z

hey @ibacher @dkayiwa i consider first working on Trunk after we just depend on mariadb, i think this will lighten the workflow and dependencies, any suggestion

achilep · 2020-08-11T21:28:50Z

thanks @sherrif10

deenoBaji

As linting mechanisms doesnot reccomend commented codes in production code. I reccomend removing the commented dependency and if need to consider that dependency in another scenario adding a complete documentation for that.

deenoBaji · 2024-03-29T19:06:55Z

pom.xml

 			<scope>compile</scope>
+         <!--This can combine all the newest driver to access all databases  -->


Please consider to remove this commented dependency.

vorburger · 2024-03-31T18:49:03Z

Hi folks, I'm the author and maintainer of MariaDB4j. OpenMRS is an awesome project and community! Just wanted to say Hi. Hope MariaDB4j works great for you? I've just released a new version a few days ago.

sherrif10 mentioned this pull request Jul 12, 2020

TRUNK-5767 migrate the MXJ to MariaDB4j openmrs/openmrs-core#3226

Closed

5 tasks

HerbertYiga reviewed Jul 13, 2020

View reviewed changes

sherrif10 force-pushed the STAND-102 branch from f56ad53 to 36b28da Compare July 14, 2020 19:24

sherrif10 force-pushed the STAND-102 branch from 9c75b6c to e63c87a Compare July 14, 2020 22:23

sherrif10 force-pushed the STAND-102 branch from 70a7498 to 0c5d8ff Compare July 20, 2020 10:15

ibacher reviewed Jul 20, 2020

View reviewed changes

sherrif10 force-pushed the STAND-102 branch 4 times, most recently from dd8c7c0 to 99585aa Compare July 23, 2020 09:05

STAND-102:Replace the embedded mysql with mariadb4j?

a1f5c04

https://issues.openmrs.org/browse/STAND-102

sherrif10 force-pushed the STAND-102 branch from 4f37a75 to a1f5c04 Compare July 23, 2020 15:56

Adding password as root in sample sql file

fae3130

sherrif10 commented Jul 30, 2020

View reviewed changes

deenoBaji reviewed Mar 29, 2024

View reviewed changes

		@@ -1,4 +1,4 @@
		<project xmlns="http//maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
		<project xmlns="http//maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

		<liquibasePluginArtifactId>liquibase-maven-plugin
		</liquibasePluginArtifactId>

		<liquibasePluginArtifactId>liquibase-plugin
		</liquibasePluginArtifactId>

		<ciel.dictionary.openmrs.version>1.9.9
		</ciel.dictionary.openmrs.version>

	<ciel.dictionary.openmrs.version>1.9.9
	</ciel.dictionary.openmrs.version>
	<ciel.dictionary.openmrs.version>1.9.9</ciel.dictionary.openmrs.version>

		<url>http://mavenrepo.openmrs.org/nexus/content/repositories/public
		</url>

		<scope>compile</scope>
		<!--This can combine all the newest driver to access all databases -->

STAND-102:Replace the embedded mysql with mariadb4j? #46

Are you sure you want to change the base?

STAND-102:Replace the embedded mysql with mariadb4j? #46

Conversation

sherrif10 commented Jul 12, 2020 • edited

dkayiwa commented Jul 12, 2020

sherrif10 commented Jul 12, 2020

sherrif10 commented Jul 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sherrif10 commented Jul 14, 2020 • edited

sherrif10 commented Jul 14, 2020

sherrif10 commented Jul 15, 2020

ibacher left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sherrif10 commented Jul 23, 2020

Choose a reason for hiding this comment

sherrif10 commented Aug 5, 2020

achilep commented Aug 11, 2020

deenoBaji left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vorburger commented Mar 31, 2024

sherrif10 commented Jul 12, 2020 •

edited

sherrif10 commented Jul 14, 2020 •

edited