Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: lcmodel.write_all_files fails without a transform #107

Closed
bennyrowland opened this issue Feb 26, 2018 · 0 comments
Closed

BUG: lcmodel.write_all_files fails without a transform #107

bennyrowland opened this issue Feb 26, 2018 · 0 comments
Assignees
@bennyrowland
Labels
bug
Milestone
0.4

Comments

@bennyrowland
Copy link
Member

When saving files for processing by LCModel, the export function write_all_files() fails if no transform is set for the MRSBase object, which is probably not necessary as when not using absolute quantification this is an unnecessary parameter. It would be better to set a default voxel size and raise a warning in this case.
@bennyrowland bennyrowland added this to the 0.4 milestone Feb 26, 2018
@bennyrowland bennyrowland self-assigned this Feb 26, 2018
@bennyrowland bennyrowland mentioned this issue Feb 26, 2018
Closed
@bennyrowland bennyrowland mentioned this issue May 22, 2018
Merged
bennyrowland added a commit that referenced this issue May 22, 2018
@bennyrowland
#BUG LCModel save_raw no longer requires a transform (#113)
d391e3d 
save_raw used to require a transform to get the voxel volume, now it
only writes the volume is a transform is available, otherwise it allows
LCModel to use the default (1ml) and warns the user that it is doing
this, as quantification may be affected.

Closes #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bennyrowland bennyrowland

Labels
bug
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@bennyrowland