ENH: channel combination methods should accept an axis parameter #128
Comments
bennyrowland
added a commit
that referenced
this issue
May 13, 2020
The functions to calculate channel combination weights, `combine_channels()` and `svd_weighting()` previously required the channels to be in the first axis of the data passed in to them. Now we can instead pass an axis parameter into the function to specify which axis contains the channels dimension. The default value of this parameter is now -2, which is the default for Suspect loaded MRSData objects. Fixes #128
bennyrowland
added a commit
that referenced
this issue
May 13, 2020
The functions to calculate channel combination weights, `combine_channels()` and `svd_weighting()` previously required the channels to be in the first axis of the data passed in to them. Now we can instead pass an axis parameter into the function to specify which axis contains the channels dimension. The default value of this parameter is now -2, which is the default for Suspect loaded MRSData objects. Fixes #128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Channel combination functions currently assume that channels is the first dimension in passed in data, which is inconvenient and means that data must often be reorganised before calling the functions. It would be better if this was brought inside the function and that the dimension containing channels can just be passed in as an axis. It would also make sense for this to default to a value of -2, which is the default axis for raw data loaded by suspect.io functions.
The text was updated successfully, but these errors were encountered: