Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCModel IO - "VOLUME = NaN" #145

Closed
bkossows opened this issue Aug 24, 2020 · 2 comments · Fixed by #148
Closed

LCModel IO - "VOLUME = NaN" #145

bkossows opened this issue Aug 24, 2020 · 2 comments · Fixed by #148

Comments

@bkossows
Copy link

For 20% Siemens TWIX data I was unable to run LCModel analysis with an error 1 FATAL ZEROVX 4. In CONTROL file there was "VOLUME = NaN" instead of a some numerical value.
B.

@bennyrowland
Copy link
Member

Hi @bkossows, this will be a problem with loading the transform data so Suspect doesn't know the voxel dimensions so when it exports it leaves this NaN for volume. Or possibly with some kind of corruption of the transform. What happens if you just run print(data.transform)? Can you share any of this problem data for me to have a look at?

@bkossows
Copy link
Author

I will send You the file by an email.

print(data.transform)

[[ nan nan nan -0.586961]
[ nan nan nan 56.045076]
[ nan nan nan 11.650538]
[ 0. 0. 0. 1. ]]

bennyrowland added a commit that referenced this issue Sep 10, 2020
This code addresses an issue reported in #145 for Siemens twix files
where voxels prescribed sagittally calculate a transform of NaNs. This
arises because in the twix file the row and column axes are not
specified, but must be calculated from the normal and a rotation from a
starting pair of axes. This starting pair of axes is not consistent but
depends on how the voxel was planned. In turn this is not described in
the file but must be deduced from the normal vector. The new code is an
attempt to solve this problem for the data files where an issue has been
reported, but may not be correct for some other class of twix files.
bennyrowland added a commit that referenced this issue Sep 11, 2020
This code addresses an issue reported in #145 for Siemens twix files
where voxels prescribed sagittally calculate a transform of NaNs. This
arises because in the twix file the row and column axes are not
specified, but must be calculated from the normal and a rotation from a
starting pair of axes. This starting pair of axes is not consistent but
depends on how the voxel was planned. In turn this is not described in
the file but must be deduced from the normal vector. The new code is an
attempt to solve this problem for the data files where an issue has been
reported, but may not be correct for some other class of twix files.

Fixes #145
bennyrowland added a commit that referenced this issue Sep 29, 2020
* #BUG Sag voxels in twix fail to calculate a transform

This code addresses an issue reported in #145 for Siemens twix files
where voxels prescribed sagittally calculate a transform of NaNs. This
arises because in the twix file the row and column axes are not
specified, but must be calculated from the normal and a rotation from a
starting pair of axes. This starting pair of axes is not consistent but
depends on how the voxel was planned. In turn this is not described in
the file but must be deduced from the normal vector. The new code is an
attempt to solve this problem for the data files where an issue has been
reported, but may not be correct for some other class of twix files.

* #BUG Sag voxels in twix fail to calculate a transform

This code addresses an issue reported in #145 for Siemens twix files
where voxels prescribed sagittally calculate a transform of NaNs. This
arises because in the twix file the row and column axes are not
specified, but must be calculated from the normal and a rotation from a
starting pair of axes. This starting pair of axes is not consistent but
depends on how the voxel was planned. In turn this is not described in
the file but must be deduced from the normal vector. The new code is an
attempt to solve this problem for the data files where an issue has been
reported, but may not be correct for some other class of twix files.

Fixes #145

* updated changelog to detail fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants