You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current model for singlet fitting uses a VARPRO approach where the linear components (the peak amplitudes) are fitted in a linear least squares step independently from the non-linear (width, frequency, phase) components. This is more efficient because no iteration is needed for those parameters, and it reduces the size of the non-linear search space, however it also makes constraints between the peak amplitudes impossible to introduce, and also gives challenges in returning fit standard errors because of the split in method. I propose to modify the singlet fitting code to use entirely non-linear methods - this will allow much greater alignment with the standard lmfit template and so give more flexibility to the fitting, allowing different optimisation algorithms to be specified, for example.
The text was updated successfully, but these errors were encountered:
This PR modifies the singlet fitting model to use the LMFit Model
functionality directly and directly returns the ModelFit result,
allowing all the relevant information from lmfit to be available,
including the covariance matrix, standard errors and confidence
intervals. The JSON file format for models is preserved, but models
can also be created directly from LMFit model components.
Closes#146
This PR modifies the singlet fitting model to use the LMFit Model
functionality directly and directly returns the ModelFit result,
allowing all the relevant information from lmfit to be available,
including the covariance matrix, standard errors and confidence
intervals. The JSON file format for models is preserved, but models
can also be created directly from LMFit model components.
Closes#146
This PR modifies the singlet fitting model to use the LMFit Model
functionality directly and directly returns the ModelFit result,
allowing all the relevant information from lmfit to be available,
including the covariance matrix, standard errors and confidence
intervals. The JSON file format for models is preserved, but models
can also be created directly from LMFit model components.
Closes#146
The current model for singlet fitting uses a VARPRO approach where the linear components (the peak amplitudes) are fitted in a linear least squares step independently from the non-linear (width, frequency, phase) components. This is more efficient because no iteration is needed for those parameters, and it reduces the size of the non-linear search space, however it also makes constraints between the peak amplitudes impossible to introduce, and also gives challenges in returning fit standard errors because of the split in method. I propose to modify the singlet fitting code to use entirely non-linear methods - this will allow much greater alignment with the standard lmfit template and so give more flexibility to the fitting, allowing different optimisation algorithms to be specified, for example.
The text was updated successfully, but these errors were encountered: