Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lcmodel.write_all_files doesn't quote strings #17

Closed
bennyrowland opened this issue Oct 5, 2016 · 0 comments
Closed

lcmodel.write_all_files doesn't quote strings #17

bennyrowland opened this issue Oct 5, 2016 · 0 comments
Assignees
@bennyrowland

Comments

@bennyrowland
Copy link
Member

LCModel .control files created by lcmodel.write_all_files don't have quotes around strings from the params dict, which breaks passing them to pylcmodel.
@bennyrowland bennyrowland self-assigned this Oct 5, 2016
bennyrowland added a commit that referenced this issue Oct 5, 2016
@bennyrowland
BUG: Fixes #17
6144feb 
Adds quotes around string parameters for .control files
bennyrowland added a commit that referenced this issue Oct 5, 2016
@bennyrowland
Merge remote-tracking branch 'origin/bug-fix-#17' into bug-fix-#17
13ae82c
@coveralls coveralls mentioned this issue Oct 5, 2016
Merged
bennyrowland added a commit that referenced this issue Oct 5, 2016
@bennyrowland
Merge pull request #18 from openmrslab/bug-fix-#17
973a03f 
bug-fix-#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bennyrowland bennyrowland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bennyrowland