There should be only one source for phase adjustments #31

lasyasreepada · 2016-10-17T18:56:01Z

Check to see how suspect.fitting.singlet.fit() performs phase adjustments for a given fid. Modify the method to use suspect.MRSData.adjust_phase() so that there is one standard protocol for phase adjustment.

…ction from the suspect API instead of implementing its own function. Deleted the phase_fid() function because it's redundant now. This addresses issue #31 Fixed some formatting in singlet.py that was causing PEP8 warnings Modified the project requirements to include numpy and lmfit

Use common phase adjust function when fitting #31

lasyasreepada self-assigned this Oct 17, 2016

lasyasreepada added the ready label Oct 18, 2016

lasyasreepada mentioned this issue Oct 19, 2016

Use common phase adjust function when fitting #31 #32

Merged

lasyasreepada added in progress and removed ready labels Oct 19, 2016

bennyrowland closed this as completed in #32 Nov 11, 2016

bennyrowland added a commit that referenced this issue Nov 11, 2016

Merge pull request #32 from openmrslab/common_phase_adjust

2254ab2

Use common phase adjust function when fitting #31

bennyrowland removed the in progress label Nov 11, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

There should be only one source for phase adjustments #31

There should be only one source for phase adjustments #31

lasyasreepada commented Oct 17, 2016 •

edited

There should be only one source for phase adjustments #31

There should be only one source for phase adjustments #31

Comments

lasyasreepada commented Oct 17, 2016 • edited

lasyasreepada commented Oct 17, 2016 •

edited