Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: some Siemens spectroscopy DICOM files are not loaded #88

Closed
bennyrowland opened this issue Oct 30, 2017 · 0 comments
Closed

BUG: some Siemens spectroscopy DICOM files are not loaded #88

bennyrowland opened this issue Oct 30, 2017 · 0 comments

Comments

@bennyrowland
Copy link
Member

Siemens DICOM files from VB17A (from Magnetom 7T) have a ProtocolSliceNumber parameters in the CSA header which is not handled by the load_siemens_dicom() function, leading to an error in import.

In addition, at this point there is probably no need to produce an error on an unrecognised CSA tag, as all essential tags are already being read in, all others are metadata at best and so if some are missing it shouldn't matter. Instead a warning could be raised which would allow users to report back if they find a new parameter to be missing, without it affecting their use of the software.

bennyrowland added a commit that referenced this issue Nov 2, 2017
load_siemens_dicom() now also loads the spatial transform for the data

Also adds a new tag (ProtocolSliceNumber) to the understood CSA header
list and moves from an error on unrecognised tags to a warning.

Fixes #94
Fixes #88
bennyrowland added a commit that referenced this issue Nov 2, 2017
load_siemens_dicom() now also loads the spatial transform for the data

Also adds a new tag (ProtocolSliceNumber) to the understood CSA header
list and moves from an error on unrecognised tags to a warning.

Fixes #94
Fixes #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant