Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: resampling of image volumes doesn't work properly for single slices #90

Closed
bennyrowland opened this issue Nov 1, 2017 · 0 comments · Fixed by #93
Closed

BUG: resampling of image volumes doesn't work properly for single slices #90

bennyrowland opened this issue Nov 1, 2017 · 0 comments · Fixed by #93
Assignees
@bennyrowland
Labels
bug
Milestone
0.4

Comments

@bennyrowland
Copy link
Member

When transforming coordinates the arrays are squeezed which can remove singlet spatial dimensions, leading to issues in interpreting the coordinate arrays.
@bennyrowland bennyrowland added this to the 0.4 milestone Nov 1, 2017
@bennyrowland bennyrowland self-assigned this Nov 1, 2017
bennyrowland added a commit that referenced this issue Nov 2, 2017
@bennyrowland
BUG: Fixes for resample()
b2195c5 
Previously sample had some issues where using a single slice for the
output shape would cause the slice dimension to be dropped when
transforming the coordinates which would interfere with doing the
interpolation. This is fixed by coercing the transformed coordinates
back into the target output shape.

In addition this brought to light another bug where the row_vector() and
col_vector() functions where swapped, which led to some transposement
problems.

Fixes #90
Fixes #92
@bennyrowland bennyrowland mentioned this issue Nov 2, 2017
Merged
bennyrowland added a commit that referenced this issue Nov 2, 2017
@bennyrowland
BUG: Fixes for resample() (#93)
32c2549 
Previously sample had some issues where using a single slice for the
output shape would cause the slice dimension to be dropped when
transforming the coordinates which would interfere with doing the
interpolation. This is fixed by coercing the transformed coordinates
back into the target output shape.

In addition this brought to light another bug where the row_vector() and
col_vector() functions where swapped, which led to some transposement
problems.

Fixes #90
Fixes #92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bennyrowland bennyrowland

Labels
bug
Projects
None yet
Milestone
0.4
Development

Successfully merging a pull request may close this issue.

BUG: Fixes for resample() openmrslab/suspect
1 participant
@bennyrowland