Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stocktake program dialog should not show if no programs #962

Closed
Chris-Petty opened this issue May 7, 2019 · 2 comments · Fixed by #963
Closed

Stocktake program dialog should not show if no programs #962

Chris-Petty opened this issue May 7, 2019 · 2 comments · Fixed by #963
Assignees
@Chris-Petty
Labels
Bug: production Bug was found or believed to be in a live release Build test: success Effort: small Small effort story/task, estimated 0-2 days Priority: high

Comments

@Chris-Petty
Copy link
Contributor

Build Number: 2.3.1

Description: Stocktake program dialog shows when there are no programs to choose from. This disrupts old workflows for sites without programs.

Reproducible: Yes

Reproduction Steps: Create stocktake on site with no programs.

Comments:
@Chris-Petty Chris-Petty added Priority: high Bug: production Bug was found or believed to be in a live release Effort: small Small effort story/task, estimated 0-2 days labels May 7, 2019
@Chris-Petty Chris-Petty self-assigned this May 7, 2019
Chris-Petty added a commit that referenced this issue May 7, 2019
@Chris-Petty
Fix #962 condition for showing program dialog in stocktakes
7757ad3
@Chris-Petty Chris-Petty mentioned this issue May 7, 2019
Merged
@Chris-Petty Chris-Petty added this to the Mobile patches 2.3.XX milestone May 7, 2019
josh-griffin added a commit that referenced this issue May 7, 2019
@josh-griffin
Merge pull request #963 from openmsupply/#962-show-stocktake-program-…
0ade758 
…dialog-if-programs

Fix #962 condition for showing program dialog in stocktakes
@josh-griffin
Copy link
Contributor

Fixed in #963

@josh-griffin josh-griffin added this to Ivory Coast Done in mobile May 7, 2019
josh-griffin pushed a commit that referenced this issue May 13, 2019
@Chris-Petty @josh-griffin
Fix #962 condition for showing program dialog in stocktakes
9c8b55a
@Chris-Petty Chris-Petty moved this from Ivory Coast Done to Vaccine Module Done in mobile May 29, 2019
@josh-griffin
Copy link
Contributor

Testing

  • Program dialog only shows when there are programs defined for a store

@josh-griffin josh-griffin moved this from To be tested to Done in mobile Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Petty Chris-Petty

Labels
Bug: production Bug was found or believed to be in a live release Build test: success Effort: small Small effort story/task, estimated 0-2 days Priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #962 condition for showing program dialog in stocktakes msupply-foundation/mobile
2 participants
@Chris-Petty @josh-griffin