Fixed incorrect locale saving in Core::vlogLnInternal(). #656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in function
Core::vlogLnInternal(...)
related to incorrect saving of the locale whenutf8=true
. It led to incorrect text output to the console after calling this function.Reason:
std::setlocale()
, if success, returns a pointer to a new locale, not an old.To recreate a bug:
Core::vlogLnInternal(.utf8=true)
call. (e.g. Input invalid command into console)