Some proper pawn native param casts #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPlayerObjectData IPlayerTextDrawData IPlayerConsoleData IPlayerDialogData
AmyrAhmady
force-pushed
the
amir/proper-param-casts
branch
from
50876f9
to
d9a7c77
Compare
Hual
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR declares
IPickup,IPlayerPickup,IGangZoneandIPlayerGangZonein SDK, derived from a base class now, so it can be used in ParamCast mechanism. Before that in our native declaration files we were using raw int32 params and having repetitive code to fetch related entity with it and do the checks in each native code block, so now using two newly provided macros, we can have param cast for entities in mixed pools.Note: This is the first step for me to add per-player actors easier.
Also there are some player data param casts for less repetitive code in many other places.