Remove nested calls to performBatchUpdates when updating header/footer
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change we can see a crash in the app using Composed because the size for an unknown cell is requested. I think this is caused by the call to `performBatchUpdates` triggering a layout before the indexes have updated.
ngptsporty
approved these changes
Mar 22, 2024
Perform item reloads in a separate batch of updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change we can see a crash in the app because the size for an unknown cell is requested. I think this is caused by the call to
performBatchUpdatestriggering a layout before the indexes have updated.