Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Handling #145

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Improve Error Handling #145

merged 3 commits into from
Mar 18, 2020

Conversation

shawnvarghese
Copy link
Collaborator

No description provided.

@@ -61,7 +61,7 @@
"organization_name": "CodeForSF",
"event_type": "Workshop",
"location": "972 Mission St.",
"city": "Oakland",
"city": "San Francisco",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updating the data here to test searching different cities.

@shawnvarghese shawnvarghese requested review from n8snyder and mikeubell and removed request for n8snyder March 2, 2020 05:32
Copy link
Collaborator

@mikeubell mikeubell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the following:
Take computer off line
go to "update approved events"
select DELETE of an event
confirm the event

This raises an error, which is not handled.

@shawnvarghese
Copy link
Collaborator Author

I did the following:
Take computer off line
go to "update approved events"
select DELETE of an event
confirm the event

This raises an error, which is not handled.

Did you face the error when running it on your local server? I can't seem to be able to reproduce it.

@mikeubell
Copy link
Collaborator

mikeubell commented Mar 4, 2020

I did the following:
Take computer off line
go to "update approved events"
select DELETE of an event
confirm the event
This raises an error, which is not handled.

Did you face the error when running it on your local server? I can't seem to be able to reproduce it.

Yes this was on my local server. What happens when you do it? Do you have a google calendar configured?

@n8snyder
Copy link
Collaborator

I found some bugs related to the search form / date picker on the home page:
When I search for a city, the date picker changes to November 1899.
When I use the date picker to pick a day, then search for a city, then pick a different day, the title/description field becomes "0" and the city field becomes blank.

Copy link
Collaborator

@mikeubell mikeubell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@shawnvarghese shawnvarghese merged commit fbc0bb1 into master Mar 18, 2020
@shawnvarghese shawnvarghese deleted the issue/101 branch March 18, 2020 04:01
@shawnvarghese shawnvarghese moved this from New to Ready in Alameda County Census Events Mar 18, 2020
@shawnvarghese shawnvarghese moved this from Ready to In progress in Alameda County Census Events Mar 18, 2020
@shawnvarghese shawnvarghese moved this from In progress to Done in Alameda County Census Events Mar 18, 2020
@shawnvarghese shawnvarghese self-assigned this Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants