Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation with dynamodb restarts when tables are created first time #1486

Closed
oasisk opened this issue Sep 12, 2023 · 3 comments
Closed

Installation with dynamodb restarts when tables are created first time #1486

oasisk opened this issue Sep 12, 2023 · 3 comments
Assignees
Labels
☢️ Bug Something isn't working

Comments

@oasisk
Copy link
Contributor

oasisk commented Sep 12, 2023

Which OpenObserve functionalities are the source of the bug?

Don't known / other

Is this a regression?

Yes

Description

When we start using dynamo db as meta store for first time, dynamo tables are created as part of init job, the same job checks if root user exists in db.

This makes app fail with /user key not found

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the version you discovered this bug in (check about page for version information)

v: 0.5.2

Anything else?

No response

@oasisk oasisk added the bug label Sep 12, 2023
@oasisk oasisk self-assigned this Sep 12, 2023
taimingl added a commit to taimingl/openobserve that referenced this issue Sep 12, 2023
@taimingl
Copy link
Collaborator

taimingl commented Sep 12, 2023

Hi @oasisk, this looks like a quick fix by handling the case where key /user/ does not exist when querying db in root_user_exists() function instead of unwrapping directly. I played with it and referenced my forked branch here. Let me know what you think, especially if there's more to it, would love to hear any pointers or suggestions.

@oasisk
Copy link
Contributor Author

oasisk commented Sep 13, 2023

@taimingl , thx a lot for suggested fix, it further fails with resource not found , working on fixing it.

@taimingl
Copy link
Collaborator

thanks for the insights @oasisk. I will look further as well and definitely follow along to see how you approach it.

@hengfeiyang hengfeiyang added ☢️ Bug Something isn't working and removed bug labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☢️ Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants