Skip to content
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.

mapping-sheet - put codelist values in when enum is in an array #6

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

odscjames
Copy link
Collaborator

See ticket 235 in CRM

@odscjames odscjames self-assigned this Oct 5, 2018
@odscjames odscjames requested a review from rhiaro October 5, 2018 16:20
Copy link
Collaborator

@rhiaro rhiaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd to me to include 'Codelist:' in the output. I understand we need something to differentiate when the values must belong to a series of strings compared to when values is the format (eg. 'uri' or 'string'). Maybe they should be different columns instead? Or is this standard for what a mapping-sheet should look like? (Relatedly, if something has a pattern in the schema, this doesn't make it to the mapping-sheet yet as far as I can see.

@odscjames
Copy link
Collaborator Author

It seems odd to me to include 'Codelist:' in the output.

That's the standard from OCDS and Kadie and Jack didn't request it changed :-)

Relatedly, if something has a pattern in the schema, this doesn't make it to the mapping-sheet yet as far as I can see.

I'll issue that.

@rhiaro
Copy link
Collaborator

rhiaro commented Oct 5, 2018

If it's standard from OCDS and everyone expects that then that's fine.. I'm just wary of anything that may encourage future string-matching. I'm probably overthinking it though.

@odscjames odscjames merged commit f199ded into master Oct 5, 2018
@odscjames odscjames deleted the mapping-sheet-enum-array branch October 5, 2018 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants