Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring as many validation tests into the schema logic as possible #516

Closed
kd-ods opened this issue Jan 12, 2024 · 6 comments
Closed

Bring as many validation tests into the schema logic as possible #516

kd-ods opened this issue Jan 12, 2024 · 6 comments
Assignees
Labels

Comments

@kd-ods
Copy link
Collaborator

kd-ods commented Jan 12, 2024

JSON schema 2020-12 allows more validation logic to be included.

We will use this spreadsheet to track the validation tests which are being built into the schema.

@kd-ods
Copy link
Collaborator Author

kd-ods commented Jan 12, 2024

I'll do an initial pass down the notes in this sheet.

@kd-ods
Copy link
Collaborator Author

kd-ods commented Mar 26, 2024

@rhiaro - I've been reviewing this spreadsheet again. I'm satisfied that we have brought as many local tests into the schema as we can... or we have dedicated open tickets for remaining logic to be added.

The outstanding question is: how complete do you think the valid and invalid test data needs to be in the repo? Are we looking at - for example - at least one valid and invalid file per field? Or should we aim to test all constraints on every field and object (i.e. put a 'y' in column F for each row).

I want to get this work set up for myself, @odscrachel and @kathryn-ods over the next day or two.

@rhiaro
Copy link
Collaborator

rhiaro commented Mar 26, 2024

We should aim to test all constraints on every field and object.

@kd-ods
Copy link
Collaborator Author

kd-ods commented Mar 26, 2024

OK.

It's fine.

It's finite.

We can do this.

@kd-ods
Copy link
Collaborator Author

kd-ods commented Apr 1, 2024

Documentation on adding test data is now in the handbook.

Valid files are being renamed to remove fermentcat_ and tecido_ prefixes. PR #616

@kathryn-ods
Copy link
Contributor

closing as all possible tests have now been added in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants