Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema requirements around the Interest object #524

Open
kathryn-ods opened this issue Jan 18, 2024 · 2 comments
Open

Schema requirements around the Interest object #524

kathryn-ods opened this issue Jan 18, 2024 · 2 comments

Comments

@kathryn-ods
Copy link
Contributor

Currently interest.startDate is an optional field.

I think we should have some guidance that all interests SHOULD have a startDate (we currently say this can be rounded to nearest month or year if there's uncertainty about the exact date) and SHOULD have an endDate if the interest has ceased.

We might even want to make it a requirement that all interests MUST have a startDate. (This might open up another question of whether we require at least one interest in every relationship statement.)

@kd-ods
Copy link
Collaborator

kd-ods commented Apr 9, 2024

The most we could go for here is a 'SHOULD' since there will be cases where the precise details of an interest are unknown.

This might open up another question of whether we require at least one interest in every relationship statement.

I think this is the important question to look at. It seems to me that it's not too big an ask to require at least one intererest per relationship. Since Interest.type can be 'unknownInterest' and directOrIndirect can be 'unknown'.

I don't think this is something that needs to be resolved for 0.4, though. Especially since we know that we have a chunk of work for the next release around Interest modelling.

I suggest we rename this issue 'Schema requirements around the Interest object' and remove from the 0.4 project.

@kathryn-ods
Copy link
Contributor Author

I suggest we rename this issue 'Schema requirements around the Interest object' and remove from the 0.4 project.

Sounds good!

@kathryn-ods kathryn-ods changed the title Should interest.startDate be a required field? Schema requirements around the Interest object Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants