Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country data #61

Closed
Tracked by #8
drcongo opened this issue Mar 2, 2022 · 10 comments
Closed
Tracked by #8

Country data #61

drcongo opened this issue Mar 2, 2022 · 10 comments

Comments

@drcongo
Copy link
Collaborator

drcongo commented Mar 2, 2022

Make downloadable country data and link it in the CountryPage

@drcongo drcongo mentioned this issue Mar 2, 2022
14 tasks
@drcongo drcongo self-assigned this Mar 2, 2022
@drcongo drcongo added this to To Do in Sprint Planner via automation Mar 2, 2022
@StephenAbbott
Copy link
Member

StephenAbbott commented Mar 9, 2022

Request to add additional fields from the Disclosure Regimes tracker to the 'Show further detail' dropdown on country profile pages:

Implementation detail title
Title of implementation [field = Title] and link title to URL for Register if [field = 5.1 Public access: Register URL] is filled in

Show further detail dropdown
Central register implemented: YES/NO [field = 4 Central]
Public access: YES/NO [field = 5.1 Public access]
Scope: SECTORAL/FULL ECONOMY [field = 2.1 Coverage: Scope]
Register launched: [YEAR] [field = 5.1.1 Year launched]
Threshold used to determine beneficial ownership: ##% [field = 1.2 Definition: Threshold]
Structured data publicly available: YES/NO [field = 6 Structured data]
Available as BODS: YES/NO [field = 6.3 Data published in BODS]
Available via API: YES/NO [field = 6.2 API available]
Available on the OO Register: YES/NO [field = 6.4 Data on OO Register]

Building on earlier conversations, we would only like these fields to show up for an implementation example when the field has been filled in on the Notion database. Blank fields should not be shown.

Reminder that we have the Annotated country profile page with links to relevant Notion fields but this image is missing these additional fields. I have updated the spreadsheet of all Notion fields).

@StephenAbbott
Copy link
Member

Also another issue spotted relating to the Notion data pulled into country profile pages: Oliver's design for the country profile pages shows text saying 'Central register: Open Ownership Register' and 'Public register: UK PSC Register' next to the two tick boxes in the Implementation of BOT boxes under the map image.

image

The idea with these tick boxes is not to have the Open Ownership Register and UK PSC Register text in place for every country but instead to replace that text with the title of the central or public register which has been implemented by that particular country (fields to check = show 'Title' from Disclosure Regimes tracker and link to '5.1 Public access: Register URL' where '5.1 Public access' = YES for Public register line or where '4 Central' = YES for Central register line).

This may involve some more logic being built into the Notion queries so happy to discuss this if implementation is going to be harder than expected.

If it can't be achieved in line with the designs, we should consider removing the additional Title text and simply using the '5.1 Public access: Register URL' field for the link where '5.1 Public access' = YES for Public register line or where '4 Central' = YES for Central register line.

@StephenAbbott
Copy link
Member

Also, how easy would it be to replicate the 'Show further detail' dropdown menus for the Commitment detail field on country profile pages as well as the Implementation detail field?

If possible, here are the 'Show further detail' fields for commitments that we'd like to be able to show where they are filled in on Notion:

Central: YES/NO [field = 'Central register' from Commitment Tracker]
Public access: YES/NO [field = 'Public register' from Commitment Tracker]
All sectors: YES/NO [field = All sectors from Commitment Tracker]

PS: I think all these fields will currently return 'True/False' from Notion API but could these be converted? Or do we need to update the Notion fields in the Commitment Tracker database?

@StephenAbbott
Copy link
Member

StephenAbbott commented Mar 14, 2022

Have received a small change request for the default texts appearing in the tickboxes on the country profile pages:

image

  • Change 'Commitment to BOT' at the top of the Commitment tickbox to say 'Committed to one or more:'
  • Change 'Implementation of BOT' at the top of the Implementation tickbox to say 'Implemented one or more:'
  • Change 'Central register' to 'Central register(s)' on both Commitment and Implementation tabs
  • Change 'Public register' to 'Public register(s)' on both Commitment and Implementation tabs

@StephenAbbott
Copy link
Member

@drcongo Have just been checking on expected behaviour with the Notion > Wagtail integration: we want Implementation details to show up on country profile pages only where STAGE = Publish in Notion data.

Italy shows an example where details about an implementation are being pulled through even though the stage is still at Legal
https://openownership.hactar.work/admin/notion/disclosureregime/inspect/39/
https://openownership.hactar.work/en/map/country/italy/

Could this behaviour be updated to only show Implementation details where STAGE = Publish?

@StephenAbbott
Copy link
Member

Design for the country profile pages has a text field under the tickboxes saying:

Data outdated/incorrect? Please let us know

The Please let us know text links to this form: https://share.hsforms.com/1ooDVGfPWQFyc93l3Bds9jA3upv4

Could this be added to all country profile pages?
image

@StephenAbbott
Copy link
Member

@drcongo On this comment above, let me know if this is achievable in the time we have left or if I should record a change request #61 (comment)

@StephenAbbott
Copy link
Member

When you search via https://openownership.hactar.work/en/search for a country name like 'Nigeria', it's great that the country profile page comes up as the first result: https://openownership.hactar.work/en/search/?q=nigeria

But the image attached to the country in Notion is not pulled through and there is no description field to display which means that the link is a little lost among all the more details search results which are returned:

image

Would it be possible for the country image to be passed through to search results? And could we add descriptions to the country profile pages which would then come up in the search results, saying something like "Find full information and resources about beneficial ownership in Nigeria on our country profile page"?

@StephenAbbott
Copy link
Member

Could we please change 'Consultant's details' to 'Contact person'?

image

@StephenAbbott
Copy link
Member

And in the 'Show further detail' dropdown from the Implementation detail section, can we change 'Title' in the first row to 'Name'? Sorry sorry sorry

image

@drcongo drcongo moved this from To Do to Sprint in Sprint Planner Mar 25, 2022
@drcongo drcongo moved this from Sprint to In progress in Sprint Planner Mar 30, 2022
@StephenAbbott StephenAbbott moved this from In progress to To Do in Sprint Planner Sep 29, 2022
@drcongo drcongo moved this from To Do to Sprint in Sprint Planner Jan 13, 2023
@drcongo drcongo moved this from Sprint to In progress in Sprint Planner Feb 21, 2023
@drcongo drcongo moved this from In progress to Done in Sprint Planner Feb 22, 2023
@drcongo drcongo moved this from Done to Staged in Sprint Planner Feb 22, 2023
@drcongo drcongo closed this as completed in edfe78d Mar 3, 2023
Sprint Planner automation moved this from Staged to Closed Mar 3, 2023
@drcongo drcongo removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants