Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSC-STM-A4: Add failure handling for invalid timepoint #243

Open
tiredpixel opened this issue Feb 28, 2024 · 2 comments
Open

PSC-STM-A4: Add failure handling for invalid timepoint #243

tiredpixel opened this issue Feb 28, 2024 · 2 comments
Assignees

Comments

@tiredpixel
Copy link
Contributor

Since the records in the stream do not last forever, it is possible that a timepoint may be used from storage which is invalid, due to age. In this case, the stream client should catch the error and should act the same way as on first start where timepoint is null.

If the timepoint being used is invalid, an error should be logged somewhere (eg Rollbar), as it is a sign some data may have been missed.

Estimate: 4 hours

@tiredpixel
Copy link
Contributor Author

I'm not sure we're actually using Rollbar in Register 2. This needs to be checked, and an approach agreed upon for this and any other failures.

@tiredpixel
Copy link
Contributor Author

tiredpixel commented Apr 19, 2024

The approach I've chosen is to log, reraise, and crash the program if the timepoint is invalid. This allows the failure to be apparent to monitoring, as well as to leave program restarts to whichever process is overseeing it.

I haven't considered Rollbar or an alternative, here, since that relates to logging and exceptions more generally. This might be addressed specifically during deployment in #246 and #247 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant