Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeCov action #56

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

dwhswenson
Copy link
Member

It looks like since #53 we haven't actually been successfully uploading coverage. I'll try to fix that here.

@dwhswenson dwhswenson added ci Improvements to continuous integration misc PR labels Oct 8, 2021
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #56 (da866bf) into main (8f6a797) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #56   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         1766      1766           
=========================================
  Hits          1766      1766           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ee0a2...da866bf. Read the comment docs.

@dwhswenson
Copy link
Member Author

Looks like this fixed it! Will consider this ready to merge immediately after review, or if no review, after 12 hours from now (no earlier than Fri 08 Oct 19:00 GMT (15:00 my local)) -- after I get some sleep.

Copy link
Member

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for not catching that earlier

@dwhswenson dwhswenson merged commit f8ed965 into openpathsampling:main Oct 8, 2021
@dwhswenson dwhswenson deleted the codecov-fix branch October 8, 2021 17:35
@dwhswenson dwhswenson mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Improvements to continuous integration misc PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants