pylint/flake8: paths_cli.compiling
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 1766 1764 -2
=========================================
- Hits 1766 1764 -2
Continue to review full report at Codecov.
|
sroet
approved these changes
Oct 31, 2021
| class CategoryPlugin(OPSPlugin): | ||
| """ | ||
| Category plugins only need to be made for top-level | ||
| """ | ||
| def __init__(self, plugin_class, aliases=None, requires_ops=(1, 0), | ||
| requires_cli=(0,4)): | ||
| requires_cli=(0, 3)): |
There was a problem hiding this comment.
this seems like an actual bugfix? should this be mentioned somewhere?
There was a problem hiding this comment.
I'd argue that it isn't a bugfix on the basis that it isn't in released code. However, I edited the main post of this PR to make mention of the change.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that my in-editor linter is working again, I went over the code in the
compilingsubpackage and cleaned up most of the things that registered as errors inpylintandflake8.I also used this as an excuse to start writing up a more detailed style guide for OpenPathSampling projects. I plan to put it in the main OPS developer docs as part of OPS 2.0 (it is Python 3 specific). The document is basically a list of "here are common cases where we allow exceptions to flake8/pylint errors and warnings" (basically, some guidelines as to when, IMHO, consistency becomes foolish consistency.)
Doc being developed in a gist: https://gist.github.com/dwhswenson/1361b849866af98e7f8e6599810670b2
EDIT: also fixes an incorrect version requirement in
CategoryPlugin, which will be part of v0.3 (not v0.4 as I originally thought).