SimStore: Fix issue with internalized snapshot box vectors #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1086 +/- ##
=======================================
Coverage 81.56% 81.56%
=======================================
Files 140 140
Lines 15451 15452 +1
=======================================
+ Hits 12603 12604 +1
Misses 2848 2848
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when using
engines.features.box_vectorsin SimStore. Previously, these were not saved.As far as I can tell, this bug only occurs if you are using the internalized Gromacs snapshots, introduced in #933, and storing them with the new SimStore storage system. (However, it could be an issue for engines that aren't included in core OPS.) The OpenMM engine uses a box vectors feature in
engines.features.staticsand the Gromacs engine uses a box vectors feature inengines.external_snapshots.features.box_vectors, so neither of these are affected. I only found this bug when I was going to suggest using SimStore + internalized snapshots as part of a user question that came up today. It seems that I overlooked this feature when adding SimStore storage support.New tests fail without the (simple) fix in the feature file and pass with the fix.