Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for OpenMM RCs #1093

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

dwhswenson
Copy link
Member

Our automated check against new OpenMM release candidates picked up a new RC last night, and the build is failing with a conda UnsatifiableError. I'm going to try to fix this on our side. Among other things, it seems like there's a weird combination trying to pull in python=3.10 while also pulling in pypy3.6, which seems like an obvious source of conflict. We don't currently test against 3.10, so I'm guessing that's the issue (this fails before we try to install the OpenMM RC, so I suspect the problem due to changes in the GitHub Actions environment, not due to the RC itself).

I'll do a little on this now, but if my first tries don't solve, I'll come back to it later in the day (after 19:00 GMT).

The offending conda command in line 17 in the "Install requirements" stage:

conda install -y -q -c conda-forge -c omnia --override-channels python=3.10   future psutil numpy scipy pandas netcdf4 svgwrite networkx matplotlib ujson!=2.*,!=3.*,!=4.0.0,!=4.0.1 mdtraj jupyter openmm!=7.5.1 openmmtools py-plumed pyemma   sqlalchemy!=1.4.0 dill   nose pytest pytest-cov coveralls nbval

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #1093 (80ce5e5) into master (72fedad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1093   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files         140      140           
  Lines       15452    15452           
=======================================
  Hits        12604    12604           
  Misses       2848     2848           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fedad...80ce5e5. Read the comment docs.

@dwhswenson dwhswenson changed the title [WIP] Fix build for OpenMM RCs Fix build for OpenMM RCs Dec 14, 2021
@dwhswenson
Copy link
Member Author

Yep, it was just a matter of needing to pin Python to 3.9, as can be seen in 6648835. Figuring out the issue with Python 3.10 will be future work; it is probably in an (optional) integration requirement, since conda-forge opened a PR to release OPS against Python 3.10 in our feedstock. In additional good news, the tests against the RC pass, so it looks like we have no problems with the RC this time.

This is ready for review and comment. I will leave it open for at least 8 hours, merging no earlier than Wed 15 Dec 00:00 GMT (Tue 14 Dec 19:00 my local).

@sroet
Copy link
Member

sroet commented Dec 14, 2021

LGTM, do you mind making an issue to remember to undo this?

@dwhswenson dwhswenson mentioned this pull request Dec 14, 2021
2 tasks
@dwhswenson dwhswenson merged commit 2414321 into openpathsampling:master Dec 15, 2021
@dwhswenson dwhswenson deleted the fix-openmm-rc-build branch December 15, 2021 17:03
@dwhswenson dwhswenson mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants