Prevent double monkey-patching experimental storage #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
==========================================
- Coverage 81.76% 81.75% -0.01%
==========================================
Files 142 142
Lines 15612 15612
==========================================
- Hits 12765 12764 -1
- Misses 2847 2848 +1
Continue to review full report at Codecov.
|
includes tests for double patching and for unpatching
dwhswenson
changed the title
|
Tests weren't quite as bad as I feared, once I sat down to write them. This is ready for review and comment. I will leave it open for at least 48 hours, merging no earlier than Thu 28 Jul 00:00 GMT (Wed 27 Jul 19:00 my local). |
sroet
requested changes
Jul 26, 2022
|
All my comments have been handled (all of them where due to me misremembering how python does things). This LGTM, feel free to merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to double monkey-patch for the experimental storage. This caused many headaches downstream (e.g., OPS CLI) because that meant that something downstream had to track state of whether OPS had been monkey-patched. It also might be the problem behind #1108. This PR makes it so that monkey-patching is idempotent.
Marked WIP because it still needs tests (which will be slightly a pain), but this is the implementation I'm planning on.