Fix Dropbox download of precalculated results #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 81.76% // Head: 81.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1128 +/- ##
==========================================
- Coverage 81.76% 81.75% -0.01%
==========================================
Files 142 142
Lines 15612 15612
==========================================
- Hits 12765 12764 -1
- Misses 2847 2848 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Apparently I needed to specify HTTP 1.1? This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Mon 09 Jan 00:00 GMT (Sun 08 Jan 18:00 my local). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something recently broke in the download of results that are used in the notebook tests.
TBH, I should probably move that into a git repo or something, instead of keeping them in my personal Dropbox. The use of my personal Dropbox for this probably predates the existence of an OpenPathSampling organization on GitHub, and (except few times I was stupid enough to move those files), it's never really caused us problems. But still. Not best practice.