Get tests working again #1132
Get tests working again #1132
Conversation
- [x] Drop Python 2 support (finally) - [x] Fix up Gromacs tests for newer grompp warnings
|
I'll leave this where it is; looks like we might need some more work to get things working on Python 3.10/3.11. This is ready for review and comment. Without review, I will merge this sometime after Sat 16 Sep 15:00 GMT (10:00 my local). |
| stdout=PIPE, | ||
| stderr=PIPE) |
There was a problem hiding this comment.
Is this actually needed? I don't see these pipes used anywhere?
There was a problem hiding this comment.
This is for the _communicate() method. It makes it so that you can get stdout/stderr -- this was somewhat useful in debugging (told me that I wasn't generating the tpr, so I knew to look at the grompp command). But it seemed like communicate is blocking (so we just run the full length trajectory, never checking if we should kill it). So PIPE/communicate are probably only useful when debugging.
Taking a few days to do some OPS upkeep; after far too much neglect. This PR will get our tests back in working order.
Importantly, as of this PR (and the next release), we're (finally) dropping Python 2.7 support. It is too much of a maintenance burden, and everyone else dropped it over 3 years ago. There should be no active projects going with Python 2.7.