Fix storage_mem_test
#498
Closed
Fix storage_mem_test
#498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review and merge. Note that #397 will also be merge with this one! |
|
Was the necessary stuff from this included in #397? (i.e., can this be closed?) |
|
Yes, this should not be merged and closed! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #447.
There was a bug in activation the observation of storable objects so the later analysis failed in the notebook. This fixes it. Since the notebook is not run as a test it should pass.
To be merged after the storage version PR #397
Contains #397 so if you merge this one. The storage version will be merged as well. Only change in this one is fixing the notebook and a few lines in
netcdfplus/base.py. Maybe that is faster than to wait that #397 passes alanine eventually.