Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed caching_mode='unlimited' #778

Merged
merged 1 commit into from Feb 23, 2020
Merged

fixed caching_mode='unlimited' #778

merged 1 commit into from Feb 23, 2020

Conversation

hejung
Copy link
Contributor

@hejung hejung commented Jun 14, 2018 •
edited by dwhswenson

See also the corresponding Issue #779 .

(Maintainer edit: closes #779)

@hejung hejung mentioned this pull request Jun 14, 2018
Closed
@jhprinz
Copy link
Contributor

jhprinz commented Jun 19, 2018

@hejung @dwhswenson I think this can be merged. Obvious typo. Thanks for fixing it.

@jhprinz jhprinz self-requested a review June 19, 2018 18:13
jhprinz
jhprinz approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@jhprinz jhprinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead

@dwhswenson
Copy link
Member

Please note that we have changed to the OPS license from LGPL (2.1 or later) to MIT. For any pull request to OPS that was started while the license was still LGPL, I need an explicit confirmation that you approve of the license change. Please add a comment with something like "The changes in this pull request are licensed under the MIT license."

@hejung
Copy link
Contributor Author

hejung commented Jul 24, 2019

The changes in this pull request are licensed under the MIT license.

@dwhswenson
Copy link
Member

@hejung : Could you do a rebase or merge our current master into this branch? I tried to re-run the CI just to be sure that it still worked (I mean, there's no way this would break anything, but always be safe). It appears re-running the build uses the .travis.yml from the original build. Our .travis.yml has changed since then, and the repo isn't compatible with the old Travis script. Thanks!

@dwhswenson dwhswenson removed the onhold label Jul 25, 2019
@hejung
Copy link
Contributor Author

hejung commented Feb 23, 2020

Done. Sorry for the delay.

@dwhswenson dwhswenson added the bugfix PRs fixing bugs label Feb 23, 2020
@dwhswenson dwhswenson merged commit 991564d into openpathsampling:master Feb 23, 2020
@dwhswenson
Copy link
Member

Thanks! Merging this.

@hejung hejung deleted the fix_caching_mode branch February 25, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhprinz jhprinz jhprinz approved these changes

Assignees
No one assigned
Labels
bugfix PRs fixing bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: caching_mode='unlimited' does not work
3 participants
@hejung @jhprinz @dwhswenson