Improve CV storage error message about missing templates #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwhswenson
changed the title
|
I'll leave this up for 24 hours to allow time for review and comment. But it's a pretty trivial fix that is definitely clearer than the previous error message. Will merge no earlier that 14:30 GMT (16:30 local) on Wed 14 Oct. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In netcdfplus, storing CVs (
PseudoAttributes) requires a template object to be already stored. Originally we only had CVs that mapped snapshots to computed values, but eventually @jhprinz added the ability to use other objects (like trajectories) as inputs. However, the error message didn't get updated, and it is very confusing to get an error message saying to save a snapshot when you already have a snapshot saved (but need to save a trajectory).This whole issue will be irrelevant with SimStore, but might as well fix the confusing error message.