Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more deterministic test for shooting point selector #964

Merged

Conversation

sroet
Copy link
Member

@sroet sroet commented Jan 22, 2021

In the doc update #963, I saw from codecov that the following line was not reliably hit in shooting.py:
Screenshot from 2021-01-22 09-18-41

This adds a test to force that code path in the first commit: 1842ed9

The second commit (31e11bf) drops nose in the test_shooting.py and uses pytest instead as an incremental update towards #756

Edit: (dc6e428) removes the duplicate of the test added in the first commit (I had copied it to a different spot around in the first commit, but forgot to remove the original one 馃う )

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #964 (7495374) into master (5384e3f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   80.25%   80.25%           
=======================================
  Files         136      136           
  Lines       14449    14449           
=======================================
  Hits        11596    11596           
  Misses       2853     2853           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5384e3f...7495374. Read the comment docs.

Copy link
Member

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think I mentioned recently that there may be a couple tests that are flaky with regards to coverage -- that is, some small fraction of lines are sometimes covered, sometimes not. This is one are where I remember that being the case. On Coveralls we allowed some small drop; we don't (yet) on CodeCov. Thanks for the fix, and the update to pytest-style!

@dwhswenson dwhswenson merged commit 5f9c545 into openpathsampling:master Jan 22, 2021
@sroet sroet deleted the make_more_deterministic_test branch January 22, 2021 10:07
@dwhswenson dwhswenson changed the title Make more deterministic test Make more deterministic test for shooting point selector Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants