New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTCIceGatherPolicy harmonization with WebRTC #224
Comments
In the current API, an RTCIceGatherer is constructed from the RTCIceGatherPolicy, but there is no method to change the RTCIceGatherPolicy after construction. As a result, an RTCIceGatherPolicy of "none" could not be changed to another value. Also, there is no way to change the iceServers once an RTCIceGatherer is constructed. So I think there is a bigger issue here. |
This |
In WebRTC 1.0 there an open issue (see: w3c/webrtc-pc#384 ), relating to harmonizing RTCIceTransportPolicy.none with the values defined in draft-ietf-rtcweb-jsep Section 4.1.1, which does not include “none” but does include “public”, which is defined as follows: “Candidates with private IP addresses [RFC1918] will be filtered out. This prevents exposure of internal network details, at the cost of requiring relay usage even for intranet calls, if the NAT does not allow hairpinning as described in [RFC4787], section 6.” |
Since "none" has now been removed from WebRTC 1.0 RTCIceTransportPolicy, I would like to close this issue and open another one related to sync'ing the new "public" setting in RTCIceTransportPolicy. |
The following WebRTC 1.0 PR will remove RTCIceTransportPolicy.public: Note that "all" no longer includes addresses that have been filtered by the browser. |
Fix for Issue #224 Related WebRTC 1.0 PR: w3c/webrtc-pc#544
@robin-raymond - can you review whether this issue is fixed and can be closed? |
ORTC has:
enum RTCIceGatherPolicy {
"all",
"nohost",
"relay"
};
WebRTC has:
enum RTCIceTransportPolicy {
"none",
"relay",
"all"
};
Consistency might be desirable with respect to "none" vs. "nohost".
The text was updated successfully, but these errors were encountered: